Skip to content

change import order to avoid circular dependency #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 10, 2025

change import order in mkl_fft/__ini__.py to avoid circular dependency that occurs in building wheel

@vtavana vtavana self-assigned this Apr 10, 2025
@ekomarova
Copy link
Collaborator

I will test this change in internal CI and let you know.

@ekomarova
Copy link
Collaborator

It works

@vtavana vtavana marked this pull request as ready for review April 11, 2025 11:42
Copy link
Collaborator

@ekomarova ekomarova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good for me and it completely fixes the issue with import

@vtavana vtavana merged commit ba40a93 into master Apr 11, 2025
49 checks passed
@vtavana vtavana deleted the circular-dep branch April 11, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants